Skip to content

RFC: replace union and intersection symbols of filters #17720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

zisoft
Copy link
Collaborator

@zisoft zisoft commented Oct 25, 2024

This PR replaces the mathematical union and intersection symbols of the color label filter with (IMO) easier to understand & for AND and || for OR.

I have marked this as RFC because this will for sure not meet everyone's taste.

fixes #15152

@ralfbrown
Copy link
Collaborator

I'm not sure non-programmers would understand the || any better than the mathematical symbol....

@ralfbrown ralfbrown added the scope: UI user interface and interactions label Oct 25, 2024
@parafin
Copy link
Member

parafin commented Oct 26, 2024

I even see a problem with & symbol - while everyone should know, that it means “and”, only in boolean logic “and” means intersection. In normal language it can mean both union and intersection (e.g. in this sentence it’s union). I would even say it’s more common for “and” to mean union.

Maybe try to come up with icons, that would symbolise phrases “narrow down” and “expand” instead.

@pehar1
Copy link

pehar1 commented Oct 26, 2024

The symbols currently used describe precisely which operation is meant. In my opinion, they should not be replaced by "&" and "||".

The ampersand ("&" sign) is a ligature, which is used as a substitute for the “and” in the commercial field (here as union, not intersection), in programming languages as address operator or for linking strings. The "||" is used in (some) programming languages, sometimes also the "|". In my opinion, this mess only increases the confusion.

Why is it too much to ask to learn these two symbols (union, intersection) again, actually they should be known from school anyway (7th grade at grammar school in Germany). And there is a helpful tooltip.

@parafin
Copy link
Member

parafin commented Oct 26, 2024

People tend to forget things. The problem with existing symbols I see is that they are too similar. And not “obvious”.

Another idea - make symbols like Venn diagram (with filled either both circles or only their intersection).

@jenshannoschwalm
Copy link
Collaborator

I simply don't know.

A simple "&" is not good to me, more correct would be "&&" if we use "||" anyway.

Venn diagrams might be better than what we have now.

@pehar1
Copy link

pehar1 commented Oct 26, 2024

Venn diagrams, in contrast to the ampersand, are logically correct representations. They therefore seem to me to be a good alternative to the currently used union and intersection symbols.

@ralfbrown
Copy link
Collaborator

We already have Venn-diagram icons in the mask manager which we can reuse if we go that way. The drawing code is in functions dtgtk_cairo_paint_masks_{union,intersection}.

@zisoft
Copy link
Collaborator Author

zisoft commented Oct 27, 2024

Next proposal:
Commit 8b72e9b uses Venn diagrams for union and intersection:

Bildschirmfoto 2024-10-27 um 18 28 45
Bildschirmfoto 2024-10-27 um 18 29 03

@TurboGit TurboGit added this to the 5.0 milestone Oct 27, 2024
@TurboGit
Copy link
Member

This sounds better to me. @ralfbrown @jenshannoschwalm @victoryforce what you view on this?

@victoryforce
Copy link
Collaborator

@TurboGit it's perfect for me.

@jenshannoschwalm
Copy link
Collaborator

Can't think of anything better now, let's take it.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 7f9fdd0 into darktable-org:master Oct 27, 2024
6 checks passed
@elstoc elstoc added the documentation-pending a documentation work is required label Oct 27, 2024
@TurboGit
Copy link
Member

@elstoc : I was about to add the documentation-pending tag that I had forgotten yesterday!

@zisoft
Copy link
Collaborator Author

zisoft commented Oct 28, 2024

Release notes:

Replaced the icon of the operator button in the color label filter for working with multiple selected color labels (union/intersection).

@TurboGit
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-complete needed documentation is merged in dtdocs scope: UI user interface and interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove union and intersection symbols of filters from the UI
8 participants