[imageio] Recognize and correctly load PFM files saved by Photoshop #17716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TurboGit Would you like me to provide a PFM file created in Photoshop for testing? |
Yes please! I'll keep this beast around as I'm from time to time test loading different format to ensure we have no regression. |
TurboGit
added
bugfix
|
OK, I'll ask a friend who has an Adobe subscription to export another image (the one where I noticed the format differences had people's faces). |
|
The image was saved as a PFM in Photoshop, zipped and attached. |
TurboGit
reviewed
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to recognize whether the PFM file was written by Adobe Photoshop, which writes the image rows in a different order. Fortunately, an unknown Adobe programmer did two things differently, not just one, when implementing a PFM writer. Usually, the image width and height metadata are written in one line, separated by a space, followed by a newline character, followed by a scaling factor. In files created by Photoshop, the width and height are each on their own line.