Skip to content

Minor documentation fix for dapr python actor sdk mock actor capability #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

lor1113
Copy link
Contributor

@lor1113 lor1113 commented May 26, 2025

Description

Added a short one liner to the python actor SDK docks explaining the limitation referenced in the issue.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #800 - It will not close the issue. I will close the issue once I have actually implemented full mocking of this, or determined that it is impossible. Nonetheless it's obviously worth updating the documentation first.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [No code changes] Code compiles correctly
  • [No code changes] Created/updated tests
  • Extended the documentation

@lor1113 lor1113 requested review from a team as code owners May 26, 2025 07:31
Signed-off-by: Lorenzo Curcio <Lorenzo.curcio@valuecuberesearch.com>
@lor1113 lor1113 force-pushed the documentation-minor branch from 9bf53e1 to db073a7 Compare May 26, 2025 08:19
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (bffb749) to head (db073a7).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
- Coverage   86.63%   86.39%   -0.24%     
==========================================
  Files          84       89       +5     
  Lines        4473     5102     +629     
==========================================
+ Hits         3875     4408     +533     
- Misses        598      694      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elena-kolevska elena-kolevska merged commit ea45284 into dapr:main Jun 1, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Actor mock testing does not currently call _on_pre/post_actor_method
2 participants