Use messages in rerun formatter #3028
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
message-based-progress-and-rerun
branch
from
300d2b1 to
da22af5
Compare
mpkorstanje
changed the title
mpkorstanje
force-pushed
the
message-based-progress-and-rerun
branch
from
da22af5 to
15cfe0f
Compare
13 tasks
mpkorstanje
commented
Jul 17, 2025
| private final Map<URI, Collection<Integer>> featureAndFailedLinesMapping = new LinkedHashMap<>(); | ||
| private final PrintWriter writer; | ||
| private final Map<String, Set<Integer>> featureAndFailedLinesMapping = new LinkedHashMap<>(); | ||
| private final Query query = new Query(); |
There was a problem hiding this comment.
Using query here seems over kill but as pickles don't have their location build in, this is the easiest way to get it. Consider putting the pickle location in the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
⚡️ What's your motivation?
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.