Skip to content

Make MYSQL_TYPE_DATETIME packet length to 11 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Make MYSQL_TYPE_DATETIME packet length to 11 #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
29545b6
Make MYSQL_TYPE_DATETIME packet length to 11
metacortex Mar 9, 2017
4444843
Fix typo
metacortex Mar 9, 2017
9671705
Fix another typo - comma
metacortex Mar 9, 2017
4bf7cfc
fix typo
metacortex Mar 9, 2017
4b4b79d
Merge branch 'master' of github.com:metacortex/crystal-mysql
metacortex Mar 9, 2017
b01bd4f
Merge branch 'master' of github.com:crystal-lang/crystal-mysql
metacortex Mar 24, 2017
f4937fd
Merge branch 'master' of github.com:crystal-lang/crystal-mysql
metacortex Mar 31, 2017
a7d563c
fix - duplicated millisec byte
metacortex Mar 31, 2017
ae670a9
Merge branch 'master' of github.com:crystal-lang/crystal-mysql
metacortex Apr 17, 2017
36cb678
Merge branch 'master' of github.com:crystal-lang/crystal-mysql
metacortex Jul 9, 2017
a952dea
Merge branch 'master' of github.com:crystal-lang/crystal-mysql
metacortex Sep 21, 2017
71f4b64
change default collation to: utf8mb4_general_ci
metacortex Oct 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/mysql/packets.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ module MySql::Protocol
packet.write_bytes caps, IO::ByteFormat::LittleEndian

packet.write_bytes 0x00000000u32, IO::ByteFormat::LittleEndian
packet.write_byte 0x21u8 # utf8_general_ci
# packet.write_byte 0x21u8 # utf8_general_ci
packet.write_byte 0x2du8 # UTF8MB4_GENERAL_CI
23.times { packet.write_byte 0_u8 }

packet << @username
Expand Down
2 changes: 1 addition & 1 deletion src/mysql/types.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ abstract struct MySql::Type
decl_type Time, 0x0bu8
decl_type DateTime, 0x0cu8, ::Time do
def self.write(packet, v : ::Time)
packet.write_blob UInt8.slice(v.year.to_i16, v.year.to_i16/256, v.month.to_i8, v.day.to_i8, v.hour.to_i8, v.minute.to_i8, v.second.to_i8, v.millisecond*1000, v.millisecond*1000/256, v.millisecond*1000/65536)
packet.write_blob UInt8.slice(v.year.to_i16, v.year.to_i16/256, v.month.to_i8, v.day.to_i8, v.hour.to_i8, v.minute.to_i8, v.second.to_i8, v.millisecond*1000, v.millisecond*1000/256, v.millisecond*1000/65536, v.millisecond*1000/16777216)
end

def self.read(packet)
Expand Down