refactor: replace searchByText with search and update extendPagination handling #1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kirti763 <kg4180553@gmail.com>
Signed-off-by: kirti763 <kg4180553@gmail.com>
|
ankita-p17
requested changes
Jul 9, 2025
| pageNumber: number = 1; | ||
| export class GetAllCredDefsDto extends PaginationDto{ | ||
|
|
||
| @ApiProperty({ required: false, example: 'id' }) |
There was a problem hiding this comment.
Please check the formatting here
There was a problem hiding this comment.
What is the purpose of this submodule?
| @@ -6,11 +6,11 @@ import { trim } from '@credebl/common/cast.helper'; | |||
| @ApiExtraModels() | |||
| export class GetWebhookDto { | |||
|
|
|||
| @ApiPropertyOptional({example: '2a041d6e-d24c-4ed9-b011-1cfc371a8b8e'}) | |||
| @IsOptional() | |||
| @ApiProperty({example: '2a041d6e-d24c-4ed9-b011-1cfc371a8b8e'}) | |||
There was a problem hiding this comment.
This is a optional property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following improvements in the connection-related files:
1. Replaced
searchByTextwithsearchsearchByTexttosearchin:connection.service.tsconnection.interfaces.tsiconnectionsearch.interface.ts2. Handled
extendPaginationextendPaginationissue: #705