Skip to content

Add SPK on Base + Update token logo #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nikozalo
Copy link

@nikozalo nikozalo commented Jun 17, 2025

Summary by CodeRabbit

  • New Features
    • Added support for the Spark (SPK) token, including its metadata and logo, to the token list.

Copy link
Contributor

coderabbitai bot commented Jun 17, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • src/public/images/1/0xc20059e0317de91738d13af027dfc4a50781b066/logo.png is excluded by !**/*.png
  • src/public/images/8453/0x692A07f2306a3bba739e5281A26A5a97C6D7A6cA/logo.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A new token, "Spark" (symbol: SPK), has been added to the project's token list and metadata files. This includes updating the main token list JSON to include Spark and introducing a dedicated metadata JSON file with details and a logo reference for the token on chain ID 8453. No existing data was altered.

Changes

File(s) Change Summary
src/public/CowSwap.json Appended a new entry for the "Spark" (SPK) token to the tokens array, specifying its details.
src/public/images/8453/0x692A07f2306a3bba739e5281A26A5a97C6D7A6cA/info.json Added a new metadata JSON file for the "Spark" token, including address, decimals, logo, and info.

Poem

In the meadow of tokens so bright,
Spark joins the list, a dazzling new light.
With eighteen decimals and a shiny new face,
It hops on the chain, ready to race.
Welcome, dear SPK, to the blockchain warren—
May your journey be bright from dusk until morn!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Jun 17, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (alfetopito)[https://github.com/alfetopito]
@nikozalo
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🔭 Outside diff range comments (1)
src/public/CowSwap.json (1)

4-8: Bump patch version after adding a new token.

Since you’re appending a new token entry, the version.patch field should be incremented (e.g., 01) to reflect this update.

🧹 Nitpick comments (1)
src/public/images/8453/0x692A07f2306a3bba739e5281A26A5a97C6D7A6cA/info.json (1)

1-10: Approve new token metadata; nit: trim trailing whitespace in reason.

The file correctly defines all required fields for SPK. The only minor issue is an extra space at the end of the reason string. Consider removing it for consistency.

-  "reason": "Spark's governance token launched by Spark's team. ",
+  "reason": "Spark's governance token launched by Spark's team."
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3034ec2 and a1fb641.

⛔ Files ignored due to path filters (2)
  • src/public/images/1/0xc20059e0317de91738d13af027dfc4a50781b066/logo.png is excluded by !**/*.png
  • src/public/images/8453/0x692A07f2306a3bba739e5281A26A5a97C6D7A6cA/logo.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • src/public/CowSwap.json (1 hunks)
  • src/public/images/8453/0x692A07f2306a3bba739e5281A26A5a97C6D7A6cA/info.json (1 hunks)

@alfetopito
Copy link
Collaborator

@nikozalo could you please sign the CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants