Skip to content

305 solve documentation #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

305 solve documentation #580

wants to merge 3 commits into from

Conversation

jbcaillau
Copy link
Member

closes #305

@jbcaillau jbcaillau linked an issue Jul 5, 2025 that may be closed by this pull request
@github-actions github-actions bot requested a review from ocots July 5, 2025 18:57
@jbcaillau
Copy link
Member Author

second thoughts: for the problem definition, i really prefer to keep the reference to the grammar written as an expression.

  • i don't think it's misleading as concrete examples are immediately provided
  • i am OK to change my mind if users complain
  • i like the fact that Julia is flexible enough to allow a description in Julia of a DSL that extends its syntax

@jbcaillau
Copy link
Member Author

@ocots @PierreMartinon @gergaud it is important to promote the ability to solve on GPU, so i've added a section "Solve on GPU". it is better if the three of you look at it, not me. i'll take care of the update of "Problem definition" section, adding remarks on the limitations due to ExaModels for GPU solving.

@jbcaillau
Copy link
Member Author

@ocots can you please recall how to generate the doc on a branch (not main)? i find it more convenient not to build locally and rely on CI in draft mode.

Copy link

github-actions bot commented Jul 5, 2025

Breakage test results
Date: 2025-07-05 21:40:08

Name Latest Stable
OptimalControlProblems.jl
Tutorials.jl

@jbcaillau jbcaillau mentioned this pull request Jul 5, 2025
@ocots
Copy link
Member

ocots commented Jul 5, 2025

second thoughts: for the problem definition, i really prefer to keep the reference to the grammar written as an expression.

  • i don't think it's misleading as concrete examples are immediately provided
  • i am OK to change my mind if users complain
  • i like the fact that Julia is flexible enough to allow a description in Julia of a DSL that extends its syntax

I think that having all the expressions at first, then the examples could be nice. Always the same, when you learn, you want details, when you already know, you want to go straight to the point. If you have all the syntax in one block, then, maybe you can retrieve something you forgot.

That's why I put the docstrings first here.

@ocots
Copy link
Member

ocots commented Jul 5, 2025

@ocots can you please recall how to generate the doc on a branch (not main)? i find it more convenient not to build locally and rely on CI in draft mode.

https://documenter.juliadocs.org/stable/lib/public/#Documenter.deploydocs

Replace

push_preview = false,

by

push_preview = true,

push_preview a boolean that specifies if preview documentation should be deployed from pull requests or not. If your published documentation is hosted at "https://USER.github.io/PACKAGE.jl/stable, by default the preview will be hosted at "https://USER.github.io/PACKAGE.jl/previews/PR##". This feature works for pull requests with head branch in the same repository, i.e. not from forks.

To access to the doc:

"https://USER.github.io/PACKAGE.jl/previews/PR##"

where you replace PR## by PR580.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solve documentation
4 participants