Prevent entire indexing process from stopping on error and surface messages to Indexing menu #6390
+237
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for continuedev pending review.Visit the deploys page to approve it
|
dosubot
bot
added
the
size:L
|
Could do a bit smaller font size on the warnings like |
…ssages to Indexing menu
tingwai
force-pushed
the
tingwai/indexing-error-handling-dont-halt-on-error
branch
from
a816e2b to
057809b
Compare
|
Tweaked UI a little per feedback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are multiple pieces in indexing process, I moved the try/catch into
this.indexFilesso the entire process is not stopped when a one or more step errors. The warnings are then collected and propagated to Indexing menu on UI (see video below)Checklist
Screenshots
I added some throw errors in code snippets and full text search functions to similar an error.
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Indexing now continues even if some steps fail, and any warnings are shown in the Indexing menu instead of stopping the whole process.