Skip to content

Dynamically switch between rendering ghost text and svg decoration based on the model output #6389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jpoly1219
Copy link
Collaborator

@jpoly1219 jpoly1219 commented Jul 2, 2025

Description

Dynamically switch between rendering ghost text and svg decoration based on the model output.
If the model output is FIM, then we render a ghost text. Else, we render a SVG decoration.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Now switches between showing ghost text or an SVG decoration based on the model output. If the output is a fill-in-the-middle (FIM) edit, ghost text is shown; otherwise, an SVG decoration is used.

@jpoly1219 jpoly1219 requested a review from a team as a code owner July 2, 2025 00:02
@jpoly1219 jpoly1219 requested review from Patrick-Erichsen and removed request for a team July 2, 2025 00:02
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 2, 2025
Copy link

netlify bot commented Jul 2, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit f4a3a96
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/68647706c5ca280008553b4c

Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a unit test would be helpful here, 1) to view sample inputs, and 2) to lock down/verify behavior

Should be a pretty easy one-shot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants