Add icon to truncate history at last tool call #6382
+138
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
✅ Deploy Preview for continuedev canceled.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 2 issues across 8 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
| @@ -319,7 +319,7 @@ export function Chat() { | |||
| inputId={item.message.id} | |||
| /> | |||
| </> | |||
| ) : item.message.role === "tool" ? null : item.message.role === | |||
| ) : item.message.role === "tool" ? null : item.message.role === // /> // toolCallId={item.message.toolCallId} // contextItems={item.contextItems} // <ToolOutput | |||
There was a problem hiding this comment.
Inline comments are left in the middle of a ternary expression, which can break code parsing and readability. Comments should not be placed within expressions like this.
Suggested change
| ) : item.message.role === "tool" ? null : item.message.role === // /> // toolCallId={item.message.toolCallId} // contextItems={item.contextItems} // <ToolOutput | |
| ) : item.message.role === "tool" ? null : item.message.role === "assistant" && |
|
|
||
| if (state.history.length && index < state.history.length) { | ||
| state.codeBlockApplyStates.curIndex = 0; | ||
| state.history = state.history.slice(0, index + 1).concat({ |
There was a problem hiding this comment.
CodeBlockApplyStates.states is not cleared when history is truncated, leaving stale apply-state entries that may refer to messages that were just removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #6333 to add an icon for truncating chat history at a given message, to allow users to interrupt mid-long agent streams
Summary by cubic
Added an icon to tool call messages that lets users truncate chat history at that point.