-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: support local slugs in document link provider #6376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for continuedev pending review.Visit the deploys page to approve it
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
I think we do support directory traversal, although this is probably a case where the functionality is the docs 😅 what are your thoughts on the security concerns @fbricon ? |
79eb09a
to
61ab27d
Compare
@fbricon I'm almost positive you've signed the CLA already but it seems to still be blocking this PR, mind commenting Also apologies but I think you need to merge |
Signed-off-by: Fred Bricon <fbricon@gmail.com>
61ab27d
to
4f9462d
Compare
Document link navigation is currently broken if a config file "uses" a local slug, e.g. a "./", "file://" or "http://" url, the ConfigYamlDocumentLinkProvider always prefixes the path with https://hub.continue.dev/ and then opens an invalid url.
This PR fixes it.
proper-local-slug-navigation.mp4
I'm hesitant to provide support for directory traversal (../..) it's often source of security issues, but I'm not even sure if continue supports it. You tell me.
The CLA has been sent to @sestinj.
Summary by cubic
Fixed document link navigation for config files that use local slugs like "./" or "file://", so links now resolve correctly instead of always pointing to https://hub.continue.dev/.