-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Update Agent/Tool Message Construction and Handling #6333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Deploy Preview for continuedev failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Adds a "Truncate chat to this message" icon in non-last tool messages, to allow users to interrupt mid-long agent streams
- Fix bug where toggling mode causes focus loss if not in main editor
- Streamline tool context item to contextItemWithId conversion, add toolCall named icon
EDIT this is no longer relevant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic found 2 issues across 9 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai
to give specific feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic found 5 issues across 22 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai
to give specific feedback.
gui/src/components/mainInput/belowMainInput/ContextItemsPeek.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/mainInput/Lump/LumpToolbar/PendingToolCallToolbar.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like there's a chance this could have been 2 PRs? I don't know exactly what the order of operations looked like while you were working on it, but just noting that this was slightly messy to review
Otherwise biggest thing is unit tests on constructMessages
And make sure to take a look at Cubic's feedback. At least the gap one is accurate
Description
Borrows ideas from @chezsmithy #5662