-
Notifications
You must be signed in to change notification settings - Fork 3.1k
UI Polish #6318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
UI Polish #6318
Conversation
✅ Deploy Preview for continuedev canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic found 2 issues across 13 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai
to give specific feedback.
@@ -7,7 +7,7 @@ export const viewDiffImpl: ToolImpl = async (args, extras) => { | |||
|
|||
return [ | |||
{ | |||
name: "Diff", | |||
name: ".diff", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the name from "Diff" to ".diff" may unintentionally affect consumers of this object who expect the previous name. Verify that all usages of this name are updated accordingly to prevent potential breakage.
name: ".diff", | |
name: "Diff", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like no changes to diff tool here?
Need to add textCodeBlockBackground
to jetbrains theme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change to .diff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you click the context item it now has syntax highlighting because it's detected as a ".diff" file. Does have the downside of it saying ".diff" instead of "Diff", but with the updated UI I'm working toward it shouldn't need to say either (at least in the GUI, just in the file tab)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we set a file URI instead? context item name as the trigger for it being detected as a diff file feels off
@sestinj see comments |
Description
Some UI improvements, including using rem instead of px, matching VS Code link colors, and showing diff syntax highlighting for diff tool output
Checklist
Summary by cubic
Improved UI consistency by switching to rem units, updated link colors to match VS Code, and added diff syntax highlighting to the diff tool output.