Skip to content

UI Polish #6318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

UI Polish #6318

wants to merge 8 commits into from

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented Jun 27, 2025

Description

Some UI improvements, including using rem instead of px, matching VS Code link colors, and showing diff syntax highlighting for diff tool output

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Summary by cubic

Improved UI consistency by switching to rem units, updated link colors to match VS Code, and added diff syntax highlighting to the diff tool output.

  • UI Polish
    • Replaced px with rem for scalable sizing.
    • Updated link and code block colors for better VS Code alignment.
    • Added syntax highlighting for diffs.
    • Refactored gradient border into its own component.

@sestinj sestinj requested a review from a team as a code owner June 27, 2025 07:32
@sestinj sestinj requested review from Patrick-Erichsen and removed request for a team June 27, 2025 07:32
Copy link

netlify bot commented Jun 27, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 4d20c8a
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6862fc84e05121000809e2b2

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 2 issues across 13 files. Review them in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

@@ -7,7 +7,7 @@ export const viewDiffImpl: ToolImpl = async (args, extras) => {

return [
{
name: "Diff",
name: ".diff",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the name from "Diff" to ".diff" may unintentionally affect consumers of this object who expect the previous name. Verify that all usages of this name are updated accordingly to prevent potential breakage.

Suggested change
name: ".diff",
name: "Diff",

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 27, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like no changes to diff tool here?

Need to add textCodeBlockBackground to jetbrains theme

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change to .diff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you click the context item it now has syntax highlighting because it's detected as a ".diff" file. Does have the downside of it saying ".diff" instead of "Diff", but with the updated UI I'm working toward it shouldn't need to say either (at least in the GUI, just in the file tab)

Copy link
Collaborator

@RomneyDa RomneyDa Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we set a file URI instead? context item name as the trigger for it being detected as a diff file feels off

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 28, 2025
@RomneyDa RomneyDa removed the request for review from Patrick-Erichsen June 28, 2025 01:05
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 30, 2025
@RomneyDa
Copy link
Collaborator

RomneyDa commented Jul 1, 2025

@sestinj see comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants