Bug fix for the MTR test galera.galera_bf_abort_lock_table (MDEV-36598). #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the MTR test galera.galera_bf_abort_lock_table failed with a timeout. The root cause for the failure was an error in the logic of the MTR test: it was possible that a table created on node 1 was not replicated to node 2 before an attempt was made to lock it on node 2. This resulted in a timeout later in the test.
sjaakola
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
The test is passing in my environment, for 300 rounds. I'm confident this works now.
However, the "SHOW ALL SLAVES STATUS" is not effective for galera appliers, as they are not regular slave worker threads. Therefore it is better to remove the wait_condition_on_error_output setting, before submitting this PR
removing the error output of the wait condition for CREATE TABLE replication.
|
Removed the "SHOW ALL SLAVES STATUS" error output of the wait condition for CREATE TABLE, as suggested by sjaakola. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the MTR test galera.galera_bf_abort_lock_table failed with a timeout. The root cause for the failure was an error in the logic of the MTR test: it was possible that a table created on node 1 was not replicated to node 2 before an attempt was made to lock it on node 2. This resulted in a timeout later in the test.