MDEV-37062 Fixes for wsrep provider options plugin #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciascid
force-pushed
the
11.4-wsrep-provider-plugin-fixes
branch
5 times, most recently
from
2727d23 to
efea7a0
Compare
sciascid
force-pushed
the
11.4-wsrep-provider-plugin-fixes
branch
from
efea7a0 to
afc8b4c
Compare
sciascid
force-pushed
the
11.4-wsrep-provider-plugin-fixes
branch
from
2a495f2 to
731e668
Compare
sciascid
force-pushed
the
11.4-wsrep-provider-plugin-fixes
branch
from
731e668 to
350365d
Compare
temeo
requested changes
Jun 19, 2025
| # Test different type of options | ||
| wsrep-provider-gcache-size=1024 | ||
| wsrep-provider-pc-npvo=ON | ||
| wsrep-provider-evs-install-timeout=8.1 |
There was a problem hiding this comment.
Maybe it would be good to use interger value to avoid potential issues with floating point representation?
There was a problem hiding this comment.
This is specifically testing integers, booleans, and floating point value.
sciascid
force-pushed
the
11.4-wsrep-provider-plugin-fixes
branch
from
350365d to
11359b5
Compare
The plugin didn't work with options given on the command line or config file.
sciascid
force-pushed
the
11.4-wsrep-provider-plugin-fixes
branch
from
11359b5 to
3a2ef05
Compare
sciascid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin didn't work with options given on the command line or config file.
GALERA_BRANCH=4.x-init-config