Skip to content

Refactor/all page #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 25, 2024
Merged

Refactor/all page #67

merged 12 commits into from
Dec 25, 2024

Conversation

ToKyun02
Copy link
Contributor

✍️ Description

전체적인 프로젝트 개선사항을 반영한 PR입니다.

  1. Header Profile 이미지 영역 CLS 처리
  2. Header Logo 이미지 영역 CLS 처리
  3. Header Banner 이미지 영역 CLS 오류 수정
  4. 페이지 에러에 따른 리디렉션으로 에러처리 구현
  5. Profile 로딩 중일 때 반환하는 컴포넌트 개선
  6. 페이지네이션 초기 로딩 처리
  7. 페이지네이션 간격 gap -> padding 으로 수정
  8. Answer 페이지 Moadl 스크롤 방지 구현
  9. 파일 찾기 쉽도록 구조 변경
  10. constant 모듈 미사용으로 인한 삭제
  11. ToastSuccess 메시지 로직 간편화
  12. getDynamicLimit 함수 util로 관리
  13. 불필요한 주석 제거

✅ Checklist

PR

  • Branch Convention 확인

    epic/ 에픽, feat/ 피쳐, fix/ 버그 수정, refactor/ 개선

  • Base Branch 확인
  • 적절한 Label 지정
  • Assignee 및 Reviewer 지정

Test

  • 로컬 작동 확인

Additional Notes

  • (없음)

@ToKyun02 ToKyun02 self-assigned this Dec 25, 2024
Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for team6openmind ready!

Name Link
🔨 Latest commit 345b5d3
🔍 Latest deploy log https://app.netlify.com/sites/team6openmind/deploys/676bab21e848ee00082076bf
😎 Deploy Preview https://deploy-preview-67--team6openmind.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ToKyun02 ToKyun02 merged commit cb6f2f0 into merge Dec 25, 2024
5 checks passed
@ToKyun02 ToKyun02 mentioned this pull request Dec 25, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant