Skip to content

fix right-side dropdown positions on mobile #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

joshreisner
Copy link
Contributor

on mobile devices, the dropdown can go off the screen, making it impossible to expand

before

this happened because a recent update switched to the nth-of-type selector, but that neglected to account for the form element in the controls

after

@joshreisner joshreisner requested review from gkovats and pjaudiomv June 18, 2025 14:55
@joshreisner joshreisner self-assigned this Jun 18, 2025
Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for tsml-ui ready!

Name Link
🔨 Latest commit 637716a
🔍 Latest deploy log https://app.netlify.com/projects/tsml-ui/deploys/6852d36ca666bf0008f92a99
😎 Deploy Preview https://deploy-preview-456--tsml-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@pjaudiomv pjaudiomv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM!

@joshreisner joshreisner merged commit 2c5fae3 into main Jun 18, 2025
6 checks passed
@joshreisner joshreisner deleted the fix-mobile-dropdown-position branch June 19, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants