-
Notifications
You must be signed in to change notification settings - Fork 61
Use docker-compose to spin up a local CockroachDB cluster for testing #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Use docker-compose to spin up a local CockroachDB cluster for testing #159
Conversation
2a3e837
to
fa01396
Compare
@gordthompson @rafiss Any interest in this change? Otherwise I will close it. |
Thanks @ckoehn . This seems to be working fine for me. I have a bunch of little shell scripts that let me bounce around to different supported versions of CrDB and spin them up for testing so I'll probably continue to use those. However, this would be very convenient for someone with docker to test against a reasonably current backend version. I notice that the version is currently pinned at v21.1.2 while the most recent version is (currently) v21.1.7. It might be nice to use
(if available) to keep people from getting stuck on an older version. |
Thanks for the comment @gordthompson. I would prefer to pin it to a specific version instead of just |
fa01396
to
81bcc50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this change!
actually, before we merge this, could you document the usage for this in one of the READMEs? |
Good idea! Will add it next week.
… On 31. Aug 2021, at 06:36, Rafi Shamim ***@***.***> wrote:
actually, before we merge this, could you document the usage for this in one of the READMEs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marking as "changes requested" for the README
This changeset introduces a three node CockroachDB cluster for local testing. All interactions are steered through the
Makefile
to streamline the whole development process.If a three node cluster is actually needed is up for discussion.