Skip to content

Use docker-compose to spin up a local CockroachDB cluster for testing #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ckoehn
Copy link
Contributor

@ckoehn ckoehn commented Jun 21, 2021

This changeset introduces a three node CockroachDB cluster for local testing. All interactions are steered through the Makefile to streamline the whole development process.

If a three node cluster is actually needed is up for discussion.

@ckoehn ckoehn force-pushed the feature/use-docker-compose-to-start-cockroachdb branch from 2a3e837 to fa01396 Compare August 22, 2021 18:40
@ckoehn
Copy link
Contributor Author

ckoehn commented Aug 22, 2021

@gordthompson @rafiss Any interest in this change? Otherwise I will close it.

@gordthompson
Copy link
Collaborator

gordthompson commented Aug 22, 2021

Thanks @ckoehn . This seems to be working fine for me. I have a bunch of little shell scripts that let me bounce around to different supported versions of CrDB and spin them up for testing so I'll probably continue to use those. However, this would be very convenient for someone with docker to test against a reasonably current backend version.

I notice that the version is currently pinned at v21.1.2 while the most recent version is (currently) v21.1.7. It might be nice to use

  image: cockroachdb/cockroach:latest

(if available) to keep people from getting stuck on an older version.

@ckoehn
Copy link
Contributor Author

ckoehn commented Aug 23, 2021

Thanks for the comment @gordthompson. I would prefer to pin it to a specific version instead of just latest to have a deterministic state. I was looking at the provided tags on docker hub and discovered latest-v21.1 which might be a good middle ground for this use case.

@ckoehn ckoehn force-pushed the feature/use-docker-compose-to-start-cockroachdb branch from fa01396 to 81bcc50 Compare August 23, 2021 20:39
Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this change!

@rafiss
Copy link
Contributor

rafiss commented Aug 31, 2021

actually, before we merge this, could you document the usage for this in one of the READMEs?

@ckoehn
Copy link
Contributor Author

ckoehn commented Sep 2, 2021 via email

Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking as "changes requested" for the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants