release-25.3: changefeedccl: add test-only assertion for checkpoint fields invariant #149362
+82
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
Previously, if the changefeed failed in a mixed-version CDC test, the test wouldn't fail until it hit the timeout. We now periodically check for changefeed failures and fail the test if one is found. Release note: None
This patch adds a `RunE` method to `Test`. Unlike the existing `Run` function, it will not immediately fatal the test if an error is encountered and will instead return the error along with the test plan so that callers may decide how to handle the error. Release note: None
This patch adds a test-only assertion that we won't ever see both checkpoint fields set on a changefeed job progress struct. It is test-only because a bug that existed on earlier versions of 25.2 could cause both checkpoint fields to be set and so the production code continues to discard the legacy checkpoint when that happens. Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-25.3-149094
branch
from
fe9d870 to
47d7478
Compare
blathers-crl
bot
added
blathers-backport
blathers-crl
bot
requested review from
herkolategan and
golgeek
and removed request for
a team
blathers-crl
bot
requested review from
andyyang890
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
the
backport
asg0451
approved these changes
Jul 2, 2025
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #149094 on behalf of @andyyang890.
Fixes #149100
roachtest: surface changefeed failures in mixed-version CDC tests
Previously, if the changefeed failed in a mixed-version CDC test,
the test wouldn't fail until it hit the timeout. We now periodically
check for changefeed failures and fail the test if one is found.
Release note: None
mixedversion: add RunE method to Test
This patch adds a
RunEmethod toTest. Unlike the existingRunfunction,it will not immediately fatal the test if an error is encountered and will
instead return the error along with the test plan so that callers may decide
how to handle the error.
Release note: None
changefeedccl: add test-only assertion for checkpoint fields invariant
This patch adds a test-only assertion that we won't ever see both
checkpoint fields set on a changefeed job progress struct. It is
test-only because a bug that existed on earlier versions of 25.2
could cause both checkpoint fields to be set and so the production
code continues to discard the legacy checkpoint when that happens.
Release note: None
Release justification: test-only change