release-25.3: sql: fix check external connection evaluation #149358
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
Previously, `CHECK EXTERNAL CONNECTION '' WITH CONCURRENCY = (SELECT 1)` would panic because its not able to evaluate an expression containing a sub query. Now, passing a sub query will fail with a user error. ``` CHECK EXTERNAL CONNECTION NULLIF WITH CONCURRENTLY = EXISTS ( ( TABLE error ) ); ERROR: subqueries are not allowed in check_external_connection SQLSTATE: 0A000 ``` Release note: none Informs: #147876 Informs: #147877
blathers-crl
bot
force-pushed
the
blathers/backport-release-25.3-149260
branch
from
29af9f6 to
372d855
Compare
blathers-crl
bot
added
blathers-backport
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
the
backport
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #149260 on behalf of @jeffswenson.
Previously,
CHECK EXTERNAL CONNECTION '' WITH CONCURRENCY = (SELECT 1)would panic because its not able to evaluate an expression containing a sub query.Now, passing a sub query will fail with a user error.
Release note: none
Informs: #147876
Informs: #147877
Release justification: a low risk fix for a recently introduced feature.