Skip to content

roachtest: disable cluster reuse for sysbench/postgres* tests #149342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

DarrylWong
Copy link
Contributor

@DarrylWong DarrylWong commented Jul 1, 2025

Installing postgres creates a lot of directories that are not properly cleaned up by a cluster wipe. Disable cluster reuse
to avoid any side effects.

Release note: none
Fixes: #149127
Fixes: #149126
Fixes: #149128

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Installing postgres creates a lot of directories that are not
properly cleaned up by a cluster wipe. Disable cluster reuse
to avoid any side effects.
@DarrylWong DarrylWong changed the title roachprod: remove postgres directory on cluster wipe roachtest: disable cluster reuse for sysbench/postgres* tests Jul 1, 2025
@DarrylWong
Copy link
Contributor Author

I tried a combination of:

sudo rm -rf /var/lib/postgresql/
sudo rm -rf /var/lib/postgresql.bak/
sudo apt-get --purge -y remove postgresql postgresql-*

but kept finding more and more directories that needed to be removed. Opted to just disable cluster reuse since cleanup seemed error prone, but fyi @tbg in case you have any strong opinions.

@DarrylWong DarrylWong requested review from a team, herkolategan and golgeek and removed request for a team July 1, 2025 16:04
@DarrylWong DarrylWong marked this pull request as ready for review July 1, 2025 16:05
@tbg
Copy link
Member

tbg commented Jul 1, 2025

Yeah, no point in reusing the postgres clusters - we should just give them fresh clusters. Sorry about the noise, and thank you for looking.

@DarrylWong
Copy link
Contributor Author

TFTR!

bors r=tbg

@craig
Copy link
Contributor

craig bot commented Jul 1, 2025

@craig craig bot merged commit 164a4ba into cockroachdb:master Jul 1, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants