Pts roachtest 3 #149340
Closed
Pts roachtest 3 #149340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, we did not measure the performance of protected timestamp creation or management. Since DB-level changefeeds will potentially create many more PTS records per job (one per watched table), we will use these metrics to establish a baseline of how long these operations take and to alert us to issues if the new DB-level feeds overwhelm the PTS record table. We will measure the speed of both creating the initial PTS records in changefeed.stage.pts.create.latency and the speed of advancing the PTS records when the frontier progresses in changefeed.stage.pts.manage.latency. We also include changefeed.stage.pts.manage_error.latency for cases where the pts management errors. Epic: none Fixes: cockroachdb#147779 Informs: cockroachdb#147780 Release note (general): This change adds new metrics: changefeed.stage.pts.create.latency, changefeed.stage.pts.manage.latency, changefeed.stage.pts.manage_error.latency, to measure the performance of managing protected ts records. <pkg>: <short description - lowercase, no final period> <what was there before: Previously, ...> <why it needed to change: This was inadequate because ...> <what you did about it: To address this, this patch ...>
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.