Skip to content

Regex Pattern updated to support both 10.1 and 10.0 Gemfire Tomcat jar file #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/java_buildpack/container/tomcat/tomcat_geode_store.rb
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,7 @@ def create_cache_client_xml

def detect_geode_tomcat_version
geode_tomcat_version = nil

geode_modules_tomcat_pattern = /ge.*-modules-tomcat(?<version>[0-9]*).*.jar/.freeze
geode_modules_tomcat_pattern = /ge.*-tomcat(?<version>[0-9]*).*.jar/.freeze
Dir.foreach(@droplet.sandbox + 'lib') do |file|
if geode_modules_tomcat_pattern.match(file)
unless geode_tomcat_version.nil?
Expand Down