Skip to content

Fraction output #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fraction output #535

wants to merge 10 commits into from

Conversation

bmg1919
Copy link
Contributor

@bmg1919 bmg1919 commented Jan 29, 2025

This may need further testing. All fraction output is mixed if numerator is larger than denominator. I can add an option for improper fractions if desired, maybe even a button to switch the current result from one to the next (mixed/improper, proper, decimal).

@clementwzk
Copy link
Owner

clementwzk commented Apr 13, 2025

Thanks for your PR, here is some changes to do before merging:

  • Add an icon to both setting options (the first one is already used by another option)
  • When you click on then result, it should display the default result (and vice versa)
  • Should not display the fraction output if there is no calculation
  • The app crashes when you put a big number like "5555555555555555" (no idea of why)
  • Perhaps change the output format to an html format like "$num/$deno", because it's very not beautiful right now

bmg1919 added 2 commits April 18, 2025 14:19
# Conflicts:
#	app/src/main/java/com/darkempire78/opencalculator/MyPreferences.kt
#	app/src/main/java/com/darkempire78/opencalculator/activities/MainActivity.kt
@clementwzk
Copy link
Owner

any news?

@bmg1919
Copy link
Contributor Author

bmg1919 commented May 11, 2025

any news?

Other than icons, I have some changes near ready to push.

@bmg1919
Copy link
Contributor Author

bmg1919 commented May 11, 2025

Thanks for your PR, here is some changes to do before merging:

  • Add an icon to both setting options (the first one is already used by another option)
  • When you click on then result, it should display the default result (and vice versa)
  • Should not display the fraction output if there is no calculation
  • The app crashes when you put a big number like "5555555555555555" (no idea of why)
  • Perhaps change the output format to an html format like "$num/$deno", because it's very not beautiful right now

I've directly addressed the issues I've marked. I need to find or make some different icons for the menu option. I did reuse the precision icon. Instead of touching the screen to switch results, it currently shows both decimal and fraction results on pressing the equals button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants