-
-
Notifications
You must be signed in to change notification settings - Fork 142
Fraction output #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fraction output #535
Conversation
Thanks for your PR, here is some changes to do before merging:
|
# Conflicts: # app/src/main/java/com/darkempire78/opencalculator/MyPreferences.kt # app/src/main/java/com/darkempire78/opencalculator/activities/MainActivity.kt
any news? |
Other than icons, I have some changes near ready to push. |
I've directly addressed the issues I've marked. I need to find or make some different icons for the menu option. I did reuse the precision icon. Instead of touching the screen to switch results, it currently shows both decimal and fraction results on pressing the equals button. |
This may need further testing. All fraction output is mixed if numerator is larger than denominator. I can add an option for improper fractions if desired, maybe even a button to switch the current result from one to the next (mixed/improper, proper, decimal).