Better support for netbean's dark themes #2
Conversation
| if (!((renderer instanceof SeverityCellView) | ||
| || this.getSelectionModel().isSelectedIndex(rowIndex))) { | ||
| if (event instanceof XMLEvent) { | ||
| jc.setBackground(new Color(236, 233, 216)); |
There was a problem hiding this comment.
thanks for your help. just have one remark:
if you remove this if statement there is no special rendering of manually loaded log4j events (from file)
Maybe we should just delete the else branch of the statement.
There was a problem hiding this comment.
Hello,
Just come back to this feature yesterday (I didn't have much time until now).
The fact is if I do not remove the entire if statement, I cannot see manually loaded log4j events with my dark theme (foreground is white and background is white).
Which "look and feel" do you use ? I've done some tests and I didn't managed to reproduce the look of your screenshot. (my guess is you're using a Mac because I've tested on Ubuntu and Windows. If my guess is right, I cannot work further on the problem because I don't have one)
Thanks
|
I added a change on Regexp text field. Foreground color is no more forced. See you Arnaud |
I just changed 2 things.
First, I removed the forced white background color on event table. Netbeans sets the default color for the current theme.
I forced the font in severity cell to black whatever the theme used.
See you
Arnaud