The previous pull request and one new commit to support ForceAuthn in AuthnRequest #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Name="givenName" Name="urn:oid:2.5.4.42" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:uri"><saml2:AttributeValue xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:type="xs:string">Oskari</saml2:AttributeValue></saml2:Attribute> used to give an empty Attribute Value, this fixes that.
…ovidername as a configurable thing. Added nameid_format into SYNOPSIS.
…t. For Shibboleth 2.x compatibility.
…XML tree inside it that has also been signed. TODO: Should remove the outermost Signature only, now it removes the first it finds in the byte stream (with a regexp). TODO: Should not need the Response namespace for matching to make XML::Sig general again.
…XML tree inside it that has also been signed. TODO: Should remove the outermost Signature only, now it removes the first it finds in the byte stream (with a regexp). TODO: Should not need the Response namespace for matching to make XML::Sig general again.
Only supported when XML::CanonicalizeXML is used.
Conflicts: lib/Net/SAML2/XML/Sig.pm
|
Hi, Sorry for the delay looking at this! I've had no chance to do any SAML work at all until just now, but I hope to get this stuff merged before too long. I've just pushed 0.17 to CPAN with a couple of smaller fixes, and then I'll be looking at the multiple-signature stuff. Chris. |
|
Any possibility to get these merged? I'd like to switch back to the upstream version of yours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForceAuthn asks Shibboleth to ask the user to login every time and not remember the login from the session, making it possible to use Shibboleth SSO without Single-Signout.