Fix minor bugs in LZ4H5 #127
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few minor bugs in lz4h5. I was unable to compile this package locally for testing, but I think this will fix the last compatibility issues I'm seeing in JuliaIO/ChunkCodecs.jl#27
These are the bugs this PR tries to fix:
This PR removes the special case
that adds these 4 null bytes and adds a check in the while loop that there is enough space for the block header.
The added
(min(dstsize - dstpos, 2147483647)),
should fix this problem.This should be fixed by moving the
and dstpos < dstsize
out of the while loop condition and instead throwing an error if the dst space left is too small.read_i4be
on line 358 can read out of bounds if there are only 3 to 1 bytes left after the first block.This PR adds a check to fix this: