Fix tutorials/http/http-server build with windows gcc #3188
+104
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaprile
reviewed
Jul 2, 2025
There was a problem hiding this comment.
You told me to take this over, last week.
Those conditionals have side issues, I just fixed one of those yesterday: FreeRTOS (for example, maybe others), can run over Linux and Windows. We must not refer to an arch as WIN32 but as MG_ARCH_WIN32; then yes, we can address compiler specifics with their signatures, but keeping in mind that the underlying arch may not be Windoze or Linux, or even Mac.
No one would probably use FreeRTOS over Linux in real life, but they do use it for development purposes. I bet ThreadX has something similar.
According to your changes, then it is not the http server that does not run, but anything that uses RSA.
I'm working on the RSA code today, I'll import this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.