-
Notifications
You must be signed in to change notification settings - Fork 7
feat: udpate action options for spaces #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
c6017ea
to
0f24256
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check the create drive. Then we merge.
We should check a better way of enabling these options, but for now it's ok to hard code this on our fork.
2ea11b2
to
3bea34f
Compare
New permission in reva: cs3org/reva#5225 |
15bf9a7
to
5a1f6c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in cs3org/reva/pull/5225, it's ok to merge now, but I would not make the appearence of the projects create button depend on wether the user has a personal space or not.
Can you split the change for the projects creation button? It would be easier to revert when we improve the backend (which you can already have a look if it would be easy, otherwise we merge the reva changes as is and keep these changes commit.) |
- update isVisible method from some actions based on cernFeatures value
5a1f6c7
to
bd2865e
Compare
new PR for Create Project button: #199 |
Uh oh!
There was an error while loading. Please reload this page.