Skip to content

feat: udpate action options for spaces #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

rodcoffani
Copy link

@rodcoffani rodcoffani commented Jul 4, 2025

  • update isVisible method from some actions based on cernFeatures value

@rodcoffani rodcoffani force-pushed the feat/update-action-options-for-spaces branch from c6017ea to 0f24256 Compare July 8, 2025 12:31
@rodcoffani rodcoffani marked this pull request as ready for review July 9, 2025 08:53
@rodcoffani rodcoffani marked this pull request as draft July 10, 2025 08:02
Copy link

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check the create drive. Then we merge.

We should check a better way of enabling these options, but for now it's ok to hard code this on our fork.

@rodcoffani rodcoffani force-pushed the feat/update-action-options-for-spaces branch 2 times, most recently from 2ea11b2 to 3bea34f Compare July 11, 2025 11:49
@rodcoffani
Copy link
Author

New permission in reva: cs3org/reva#5225

@rodcoffani rodcoffani marked this pull request as ready for review July 11, 2025 12:01
@rodcoffani rodcoffani requested a review from diocas July 11, 2025 12:01
@rodcoffani rodcoffani force-pushed the feat/update-action-options-for-spaces branch 2 times, most recently from 15bf9a7 to 5a1f6c7 Compare July 17, 2025 07:47
Copy link

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in cs3org/reva/pull/5225, it's ok to merge now, but I would not make the appearence of the projects create button depend on wether the user has a personal space or not.

@diocas
Copy link

diocas commented Jul 17, 2025

Can you split the change for the projects creation button? It would be easier to revert when we improve the backend (which you can already have a look if it would be easy, otherwise we merge the reva changes as is and keep these changes commit.)

- update isVisible method from some actions based on cernFeatures value
@rodcoffani rodcoffani force-pushed the feat/update-action-options-for-spaces branch from 5a1f6c7 to bd2865e Compare July 18, 2025 09:24
@rodcoffani
Copy link
Author

rodcoffani commented Jul 18, 2025

new PR for Create Project button: #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants