-
Notifications
You must be signed in to change notification settings - Fork 101
Integrating brainstate
, brainevent
into brainpy
#763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chaoming0625
wants to merge
23
commits into
master
Choose a base branch
from
update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…streamline value handling
…nclude brainstate, brainunit, and brainevent
This commit introduces a `pyproject.toml` file to enable seamless installation using UV, the modern Python package installer.
All calls to bm.clear_buffer_memory() in test_aligns.py have been commented out, likely to prevent buffer clearing during test execution or debugging. Additionally, the unused reduce_axes argument and its documentation were removed from grad() in autograd.py for code simplification.
Renamed the Base class in ndarray.py to BaseArray and updated all references in related modules, including Array and Variable. Also fixed the while_loop wrapper in controls.py to correctly unpack operands for the body and condition functions. Uncommented bm.clear_buffer_memory() calls in test_aligns.py to ensure buffer memory is cleared after tests.
Introduced a private method to ensure the random state value exists and is valid. If the value is deleted, it is regenerated before being accessed.
Replaces all references to 'Array' with 'BaseArray' in type checks and imports to align with updated class naming. This improves consistency and clarity in the codebase.
Updated the _ensure_value_exists method to properly check the type of self._value and only regenerate the random state if it is not a numpy array, not a JAX Tracer, and has been deleted. This prevents unnecessary regeneration and ensures correct handling of different value types.
Updated the scan function to use correct argument names ('f' and 'pbar') for brainstate.transform.scan. Fixed while_loop to properly wrap cond_fun in a lambda, matching the expected signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.