Skip to content

Input/select placeholder font change #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions toolkit/chakra/input-group.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const InputGroup = React.forwardRef<HTMLDivElement, InputGroupProps>(
return (
<Group ref={ ref } w="100%" { ...rest }>
{ startElement && (
<InputElement pointerEvents="none" ref={ startElementRef } px={ 0 } color="gray.500" { ...startElementProps }>
<InputElement pointerEvents="none" ref={ startElementRef } px={ 0 } color="input.placeholder" { ...startElementProps }>
{ startElement }
</InputElement>
) }
Expand All @@ -76,7 +76,7 @@ export const InputGroup = React.forwardRef<HTMLDivElement, InputGroupProps>(
});
}) }
{ endElement && (
<InputElement placement="end" ref={ endElementRef } px={ 0 } color="gray.500" { ...endElementProps }>
<InputElement placement="end" ref={ endElementRef } px={ 0 } color="input.placeholder" { ...endElementProps }>
{ endElement }
</InputElement>
) }
Expand Down
8 changes: 4 additions & 4 deletions toolkit/theme/foundations/semanticTokens.ts
Original file line number Diff line number Diff line change
Expand Up @@ -268,13 +268,13 @@ const semanticTokens: ThemingConfig['semanticTokens'] = {
error: { value: '{colors.red.500}' },
},
placeholder: {
DEFAULT: { value: '{colors.gray.500}' },
DEFAULT: { value: { _light: '{colors.gray.400}', _dark: '{colors.gray.500}' } },
error: { value: '{colors.red.500}' },
},
},
field: {
placeholder: {
DEFAULT: { value: '{colors.gray.500}' },
DEFAULT: { value: { _light: '{colors.gray.400}', _dark: '{colors.gray.500}' } },
disabled: { value: '{colors.gray.500/20}' },
error: { value: '{colors.red.500}' },
},
Expand Down Expand Up @@ -305,12 +305,12 @@ const semanticTokens: ThemingConfig['semanticTokens'] = {
},
indicator: {
fg: {
DEFAULT: { value: '{colors.gray.500}' },
DEFAULT: { value: { _light: '{colors.gray.400}', _dark: '{colors.gray.500}' } },
},
},
placeholder: {
fg: {
DEFAULT: { value: '{colors.gray.500}' },
DEFAULT: { value: { _light: '{colors.gray.400}', _dark: '{colors.gray.500}' } },
error: { value: '{colors.red.500}' },
},
},
Expand Down
1 change: 1 addition & 0 deletions toolkit/theme/recipes/input.recipe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export const recipe = defineRecipe({
color: 'input.fg',
'--focus-color': 'colors.border.error',
'--error-color': 'colors.border.error',
fontWeight: 'medium',
_invalid: {
focusRingColor: 'var(--error-color)',
borderColor: 'var(--error-color)',
Expand Down
2 changes: 1 addition & 1 deletion toolkit/theme/recipes/select.recipe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const recipe = defineSlotRecipe({
borderRadius: 'base',
userSelect: 'none',
textAlign: 'start',
fontWeight: 'semibold',
fontWeight: 'medium',
cursor: 'pointer',
focusVisibleRing: 'none',
_disabled: {
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui/blob/__screenshots__/BlobData.pw.tsx_default_image-1.png
Binary file modified ui/blob/__screenshots__/BlobData.pw.tsx_default_image-2.png
Binary file modified ui/blob/__screenshots__/BlobData.pw.tsx_default_text-1.png
Binary file modified ui/blob/__screenshots__/BlobData.pw.tsx_default_text-2.png
Diff not rendered.
Diff not rendered.
Binary file modified ui/pages/__screenshots__/NameDomains.pw.tsx_default_filters-1.png
Diff not rendered.
Diff not rendered.
Diff not rendered.
Loading