Getting cabal build working with modern GHC #79
Conversation
upgrade to ghc 9.8.4 and some dependencies, tests pass locally
|
Hi @bjpop could you please run CI ? Thank you |
|
|
||
| packages: | ||
| - . | ||
|
|
||
| extra-deps: [] | ||
|
|
||
| system-ghc: false | ||
| install-ghc: true |
There was a problem hiding this comment.
Why hardwire these settings here?
E.g. I always work with the opposite settings.
| language-python-test | ||
|
|
||
|
|
||
| with-compiler: ghc-9.8.4 |
There was a problem hiding this comment.
Why hardwire the compiler version here?
| @@ -1,5 +1,5 @@ | |||
| name: language-python-test | |||
| version: 0.6.0 | |||
| version: 0.6.2 | |||
There was a problem hiding this comment.
Why does this PR contain a version bump?
The released version is 0.5.8
| utf8-string >= 1 && < 2 | ||
| build-tools: happy, alex | ||
| build-tools: happy >= 1.20, alex | ||
| build-tool-depends: happy:happy |
There was a problem hiding this comment.
One should not have both build-tools (the old, deprecated way) and build-tool-depends.
|
My apologies. A few of these changes were accidentally included, including a fews used to help Cubix build but not strictly necessary. It is very good to learn about build-tool-depends. I've had issues including happy and alex in other projects, and now I should be able to fix them. Due to very heavy work pressure, and not needing this merged upstream since we depend on our fork, and knowing that no-one else can use the library until this or similar is merged, I unfortunately must decline to take on the work of correcting the PR. I leave that to the rest of the user base. |
|
Sorry for the delay in looking into this. Shall I close this PR? |
I'd suggest so. Please consider PR #82 instead. |
No description provided.