Skip to content

[Test] Fix tests test_pcluster_configure and test_build_image #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gmarciani
Copy link
Contributor

@gmarciani gmarciani commented Jul 14, 2025

Description of changes

Fix the following integration tests:

  1. test_pcluster_configure: the test has always assumed that the free tier only returns t*.micro instance types. However, new instance types have been recently dded to the free tier by AWS, so the test started failing intermittently because we cannot guarantee the t*.micro are returned as first element by EC2. The fix consists in making the test more flexible and succeed as long as the proposed instance type belong to the free tier, despite being a t*micro type.
  2. test_build_image: the test started failing consistently on Rocky9 because the test was using our first stage AMI as parent image, which is Rocky9.5 that does not gets updates, ultimately leading to build failing when the cookbook attempts top install OS packages due to kernel pinning. With this change we are now validating the build image on the latest Rocky9 image (as of today Rocky9.6) also setting UpdateOsPackages to true.
    Notice that Rocky 9.5 reached end os support on June 4th, 2025; so it's even better to start tracking the build-image on the new version, which is Rocky 9.6..

Tests

  • [SUCCESS] test_pcluster_configure
  • [SUCCESS] test_build_image on rocky9

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani added skip-changelog-update Disables the check that enforces changelog updates in PRs Test labels Jul 14, 2025
@gmarciani gmarciani force-pushed the wip/mgiacomo/3132/integ-tests-0710-1 branch from 75d04ca to d152688 Compare July 14, 2025 22:23
@gmarciani gmarciani force-pushed the wip/mgiacomo/3132/integ-tests-0710-1 branch 4 times, most recently from 2d38ad8 to b480625 Compare July 14, 2025 22:40
@gmarciani gmarciani force-pushed the wip/mgiacomo/3132/integ-tests-0710-1 branch 10 times, most recently from 73f0953 to d034282 Compare July 15, 2025 04:30
@gmarciani gmarciani marked this pull request as ready for review July 15, 2025 13:55
@gmarciani gmarciani requested review from a team as code owners July 15, 2025 13:55
…pdate packages. This is because we want to guarantee that we work on the latest version of Rocky9. As a consequence, we need to disable the installation of Lustre for this test case (as we do for other OSes) because we cannot guarantee that Lustre releases the client on time with the updated version, and we want the test to be decoupled from it.
…instance types are taken from the current free tier.
@gmarciani gmarciani force-pushed the wip/mgiacomo/3132/integ-tests-0710-1 branch from 1f44651 to 2a14cba Compare July 15, 2025 19:17
@gmarciani gmarciani merged commit a92dd06 into aws:release-3.13 Jul 15, 2025
43 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/3132/integ-tests-0710-1 branch July 15, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants