Skip to content

Return RegionalHostedZoneId from the cloudformation UI stack #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return RegionalHostedZoneId from the cloudformation UI stack #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion infrastructure/parallelcluster-ui.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1109,8 +1109,15 @@ Outputs:
Condition: UseCustomDomain
Description: |
The endpoint associated with the custom domain name.
Add an A record in your DNS for the PCUI custom domain name pointing to this endpoint.
Add an A alias record in your DNS for the PCUI custom domain name pointing to this endpoint.
https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/routing-to-api-gateway.html#routing-to-api-gateway-config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually do not expose URLs we are not in direct control of as they may change over time.
This URL is owned by the Route53 team, not us.
May you please remove it?
Thanks

Value: !GetAtt ApiGatewayCustomDomain.RegionalDomainName
CustomDomainRegionalHostedZoneId:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this extra info to configured the DNS?
May you please clarify what's the use case where CustomDomainEndpoint is not enough?
Thank you

Condition: UseCustomDomain
Description: |
The region-specific Amazon Route 53 Hosted Zone ID of the regional endpoint.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you please rephrase The Route 53 Hosted Zone ID of the regional endpoint.
"region-specific" is redundant here because of "regional endpoint".

You need this while creating Route53 alias
Value: !GetAtt ApiGatewayCustomDomain.RegionalHostedZoneId
AppClientId:
Description: The id of the Cognito app client
Value: !Ref CognitoAppClient
Expand Down