Remove berkshelf #2989
Merged
Remove berkshelf #2989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanwen-cluster
force-pushed
the
developjul8
branch
10 times, most recently
from
882812b to
49bd4df
Compare
Berkshelf is a dependency manager for Chef cookbooks. With it, you can depend on community cookbooks and include them in your workflow. Berkshelf is not useful when all cookbooks are local. ParallelCluster cookbook has all third party cookbooks ready locally. Reducing software we depend on improves stability of the product. (e.g we have one known issue related to berkshelf https://github.com/aws/aws-parallelcluster/wiki/(3.8.0-%E2%80%90-3.9.3)-ParallelCluster-Build-Image-Failing-during-Installation-of-Minitar-Ruby-Gem-Dependency) Signed-off-by: Hanwen <hanwenli@amazon.com>
Without berkshelf, we need the names to be without the version string to let CINC recognize the cookbooks. Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-cluster
force-pushed
the
developjul8
branch
from
49bd4df to
0aceb2e
Compare
Without berkshelf, we need the cookbooks to be under the same directory to let CINC recognize the cookbooks. We can configure CINC with multiple folders of cookbooks, but need significant extra effort. Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-cluster
force-pushed
the
developjul8
branch
from
0aceb2e to
5dfebc5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2989 +/- ##
========================================
Coverage 75.50% 75.50%
========================================
Files 23 23
Lines 2356 2356
========================================
Hits 1779 1779
Misses 577 577
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hgreebe
approved these changes
Jul 9, 2025
hanwen-cluster
added
the
skip-security-exclusions-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Berkshelf is a dependency manager for Chef cookbooks. With it, you can depend on community cookbooks and include them in your workflow. Berkshelf is not useful when all cookbooks are local. ParallelCluster cookbook has all third party cookbooks ready locally.
Reducing software we depend on improves stability of the product. (e.g we have one known issue related to berkshelf https://github.com/aws/aws-parallelcluster/wiki/(3.8.0-%E2%80%90-3.9.3)-ParallelCluster-Build-Image-Failing-during-Installation-of-Minitar-Ruby-Gem-Dependency)
Reviewing by commits is easier
Tests
This must be merged together with CLI PR aws/aws-parallelcluster#6909
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.