Skip to content

Not running is_fleet_ready checks if static node count is 0 #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

himani2411
Copy link
Contributor

Description of changes

Initial PR was closed as I forced push some changes #2960

  • Adding log for checking output
  • Using Ruby yaml for looping to get count od static nodes
  • Run static fleet checks if there are any static nodes

Tests

ruby_block[wait for static fleet capacity] action run[2025-06-17T15:34:30+00:00] INFO: Processing ruby_block[wait for static fleet capacity] action run (aws-parallelcluster-slurm::finalize_head_node line 197)
[2025-06-17T15:34:30+00:00] INFO: Count of cluster static nodes is 0
[2025-06-17T15:34:30+00:00] INFO: Static fleet capacity is ready

  ruby_block[wait for static fleet capacity] action run[2025-06-17T15:43:04+00:00] INFO: Processing ruby_block[wait for static fleet capacity] action run (aws-parallelcluster-entrypoints::test line 197)
[2025-06-17T15:43:04+00:00] INFO: Count of cluster static nodes is 12
[2025-06-17T15:43:04+00:00] INFO: Static fleet capacity is ready
[2025-06-17T15:43:04+00:00] INFO: ruby_block[wait for static fleet capacity] called

Tests

  • Manual test
  • ONGOING BELOW
test-suites:
  update:
    test_update.py::test_dynamic_file_systems_update:
      dimensions:
      - instances:
        - c5.xlarge
        oss:
        - alinux2023
        regions:
        - eu-west-2
        schedulers:
        - slurm
    test_update.py::test_dynamic_file_systems_update_data_loss:
      dimensions:
      - instances:
        - c5.xlarge
        oss:
        - rhel9
        regions:
        - eu-west-2
        schedulers:
        - slurm
    test_update.py::test_dynamic_file_systems_update_rollback:
      dimensions:
      - instances:
        - c5.xlarge
        oss:
        - rocky9
        regions:
        - rocky9
        schedulers:
        - slurm
    test_update.py::test_login_nodes_update:
      dimensions:
      - instances:
        - c5.xlarge
        oss:
        - rhel8
        regions:
        - us-east-2
        schedulers:
        - slurm
    test_update.py::test_multi_az_create_and_update:
      dimensions:
      - instances:
        - c5.xlarge
        oss:
        - alinux2
        regions:
        - eu-west-2
        schedulers:
        - slurm
    test_update.py::test_update_slurm:
      dimensions:
      - instances:
        - c5.xlarge
        oss:
        - rhel8
        regions:
        - eu-central-1

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

 * Adding log for checking output
 * Using Ruby yaml for looping to get count od static nodes
 * Run static fleet checks if there are any static nodes
@himani2411 himani2411 force-pushed the develop-min-count-ad branch from 8e2db64 to abfa7cf Compare July 11, 2025 16:28
@gmarciani
Copy link
Contributor

LGTM, will approve once the test completes

@himani2411 himani2411 merged commit 478eb39 into aws:develop Jul 11, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants