Skip to content

Show the start time instead of the end time in the results history #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions source/console/src/Components/History/History.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,32 @@ class History extends React.Component {

render() {
const history = this.props.data.history || [];

// Enrich the history with more data, and sort by start time.
const resultsHistory = history.map((testRun) => {
const loadInfo = testRun.testTaskConfigs.reduce(
(previous, current) => ({
taskCount: previous.taskCount + current.taskCount,
concurrency: previous.concurrency + current.concurrency,
}),
{ taskCount: 0, concurrency: 0 }
);
const data = this.getHistoricalTest(testRun);
return {
testRun,
data,
loadInfo,
};
});
resultsHistory.sort((a, b) => new Date(b.testRun.startTime) - new Date(a.testRun.startTime));
return (
<div>
<div className="box">
<h2>Results History</h2>
<Table borderless responsive>
<thead>
<tr>
<th>Run Time</th>
<th>Started at</th>
<th>Total Task Count</th>
<th>Total Concurrency</th>
<th>Average Response Time</th>
Expand All @@ -66,23 +84,18 @@ class History extends React.Component {
</tr>
</thead>
<tbody>
{history.map((i, index) => {
const loadInfo = i.testTaskConfigs.reduce((previous, current) => ({
taskCount: previous.taskCount + current.taskCount,
concurrency: previous.concurrency + current.concurrency,
}));
const data = this.getHistoricalTest(i);
{resultsHistory.map(({ testRun, data, loadInfo }, index) => {
return (
<tr
id={`historyRow-${index}`}
key={i.testRunId}
key={testRun.testRunId}
className={this.state.rowIsActive === index ? "rowActive" : ""}
>
<td id={`endTime-${index}`}>{i.endTime}</td>
<td id={`startTime-${index}`}>{testRun.startTime}</td>
<td id={`taskCount-${index}`}>{loadInfo.taskCount}</td>
<td id={`concurrency-${index}`}>{loadInfo.concurrency}</td>
<td id={`avgResponseTime-${index}`}>{i.results.total?.avg_rt}s</td>
<td id={`successPercent-${index}`}>{i.succPercent}%</td>
<td id={`avgResponseTime-${index}`}>{testRun.results.total?.avg_rt}s</td>
<td id={`successPercent-${index}`}>{testRun.succPercent}%</td>
<td id={`detailsLink-${index}`}>
<div className="text-link history-link" onClick={() => this.onClick(index)}>
View details
Expand All @@ -101,7 +114,9 @@ class History extends React.Component {
this.setState({ rowIsActive: -1 });
}}
>
<h2>Test run from {i.endTime}</h2>
<h2>
Test run from {testRun.startTime} to {testRun.endTime}
</h2>
</ModalHeader>
<ModalBody>
<DetailsTable
Expand Down