Skip to content

docs(idempotency): simplify snippets #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

In #4145 we applied some new formatting to the codebase, however in doing so we mistakenly made redundant some try/catch blocks in code snippets. This created many SonarQube findings once the PR was merged.

This PR refactor many of the Idempotency snippets to remove these redundant try/catch blocks and simplify the examples in the process. Error handling has been left only in examples that benefit from it.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #4149


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from svozza July 8, 2025 21:23
@dreamorosi dreamorosi self-assigned this Jul 8, 2025
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jul 8, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jul 8, 2025
@dreamorosi dreamorosi linked an issue Jul 8, 2025 that may be closed by this pull request
2 tasks
Copy link

sonarqubecloud bot commented Jul 9, 2025

@dreamorosi dreamorosi merged commit 6dd18a0 into main Jul 9, 2025
46 checks passed
@dreamorosi dreamorosi deleted the docs/idempotency_snippets branch July 9, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: remove redundant code from idempotency snippets
2 participants