-
Notifications
You must be signed in to change notification settings - Fork 159
chore: bump biome formatter to next major & reformat #4145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+966
−1,080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svozza
reviewed
Jul 8, 2025
examples/snippets/event-handler/bedrock-agents/stopConversation.ts
Outdated
Show resolved
Hide resolved
Thanks for this, made reviewing the changes much easier. |
|
svozza
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automation
This item relates to automation
dependencies
Changes that touch dependencies, e.g. Dependabot, etc.
documentation
Improvements or additions to documentation
internal
PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR manually bumps
@biomejs/biome
to the latest version (2.x
) which constitutes a major release upgrade for us since we were stuck at1.x
.The upgrade introduces a couple new rules that are a good thing for the project, but that required some manual attention. The changes focus almost exclusively on import sorting and unused variables.
Since the PR diff is very big, I tried to address each package in a dedicated commit and I suggest reviewers to use the dropdown at the top-left of the PR view to select the commits while reviewing to limit the number of files.
Aside from that, apologies in advance for the big PR, splitting the work in multiple PRs would've required changes to the CI to support both versions at the same time and it wasn't worth it.
I also don't expect reviewers to look at every single file, but rather get a gist of the changes and review it as a whole, knowing that the tests are still passing.
Issue number: closes #4144
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.