Simplex QuorumCertificate and BLS aggregator #4091
Open
+380
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
yacovm
reviewed
Jul 16, 2025
samliok
commented
Jul 16, 2025
|
|
||
| bytes, err := Codec.Marshal(CodecVersion, serializedQC) | ||
| if err != nil { | ||
| panic(fmt.Errorf("failed to marshal QC: %w", err)) |
There was a problem hiding this comment.
todo: don't panic, update the simplex interface to allow an error return value
yacovm
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implements the simplex
QuorumCertificate,QCDeserializerandSignatureAggregatorinterfaces. This allows simplex to parse, aggregate and verify quorum certificates(ex. finalizations and notarizations) during execution.How this works
asn1How this was tested
Added unit tests to
bls_test.go.Need to be documented in RELEASES.md?
no