-
Notifications
You must be signed in to change notification settings - Fork 772
feat: add eviction callback in LRU cache #4088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DracoLi
wants to merge
2
commits into
master
Choose a base branch
from
dl/lru-on-evict
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+59
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds an optional eviction callback (onEvict
) to the LRU cache API and verifies its behavior in unit tests.
- Introduces
SetOnEvict
to register a callback invoked before entries are removed. - Updates
Put
,Evict
, andFlush
methods to trigger the callback on eviction. - Adds tests for eviction and flush scenarios with callbacks.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
cache/lru/cache.go | Added onEvict field, SetOnEvict and invocation in Put , Evict , and Flush . |
cache/lru/cache_test.go | Added tests for flush and put evictions using onEvict . |
Comments suppressed due to low confidence (1)
cache/lru/cache.go:73
- There’s no unit test covering the Evict method when an onEvict callback is set. Consider adding a test to ensure onEvict is called when an entry is explicitly evicted via Evict().
c.lock.Lock()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds an optional
onEvict
callback to the LRU cache to allow resource cleanup when entries are evicted.x/blockdb
(#4027) uses the LRU cache to store file descriptors, so this allowsblockdb
to properly close the file descriptors when an entry is evicted.How this works
SetOnEvict(callback)
method to set an optional cleanup functionPut
,Evict
, orFlush
)How this was tested
Unit tests added
Need to be documented in RELEASES.md?
Don't think so