-
Notifications
You must be signed in to change notification settings - Fork 772
chore: replace polling with subscription-based acceptance #4059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RodrigoVillar
wants to merge
5
commits into
master
Choose a base branch
from
replace-polling-w-events
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces polling-based transaction confirmation with a subscription to new blocks and nonce inspection.
- Introduces a block subscription in
Wallet.SendTx
and refactorsawaitTx
to listen for headers. - Removes
pingFrequency
and related polling logic. - Updates tests to drop the
PollFrequency
field and adjust calls accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/load2/wallet.go | Adds block‐subscription logic, refactors awaitTx . |
tests/load2/tests.go | Removes PollFrequency field and argument. |
tests/load2/main/main.go | Updates instantiation of ZeroTransferTest . |
Comments suppressed due to low confidence (1)
tests/load2/wallet.go:119
- [nitpick] Consider including the transaction hash or more context in this error (e.g., the txHash) to make failures easier to debug.
return fmt.Errorf("failed tx: %d", receipt.Status)
maru-ava
reviewed
Jul 8, 2025
maru-ava
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
As mentioned in #3996 (comment), we should not be polling API nodes for a transaction's status in the context of load testing. This PR modifies the
awaitTx()
to use block-subscriptions instead of excessive polling for determining a transaction's status.How this works
For each block
awaitTx()
hears about,awaitTx()
queries the nonce of the sender at the given height to determine if the sender's nonce has incremented by one (i.e. if the sender's outstanding transaction was included in a block). If the nonce has incremented,awaitTx()
then makes a single call toclient.TransactionReceipt()
to determine if the transaction successfully executed or not.How this was tested
CI
Need to be documented in RELEASES.md?
N/A