test: Add tests for combination queries and loading calculations #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rellen
commented
Jul 7, 2025
Comment on lines
+10
to
+56
| test "combination query with allow_nil? calculation loses ORDER BY" do | ||
| Post | ||
| |> Ash.Changeset.for_create(:create, %{title: "Zebra", score: 5}) | ||
| |> Ash.create!() | ||
|
|
||
| Post | ||
| |> Ash.Changeset.for_create(:create, %{title: "Apple", score: 25}) | ||
| |> Ash.create!() | ||
|
|
||
| Post | ||
| |> Ash.Changeset.for_create(:create, %{title: "Dog", score: 10}) | ||
| |> Ash.create!() | ||
|
|
||
| Post | ||
| |> Ash.Changeset.for_create(:create, %{title: "Cat", score: 20}) | ||
| |> Ash.create!() | ||
|
|
||
| query = | ||
| Post | ||
| |> Ash.Query.sort([{:title, :asc}]) | ||
| |> Ash.Query.load([:latest_comment_title]) | ||
| |> Ash.Query.combination_of([ | ||
| Ash.Query.Combination.base( | ||
| filter: expr(score < 15), | ||
| calculations: %{ | ||
| sort_order: calc(score * 20, type: :integer) | ||
| }, | ||
| sort: [{calc(score * 20, type: :integer), :desc}] | ||
| ), | ||
| Ash.Query.Combination.union( | ||
| filter: expr(score >= 15), | ||
| calculations: %{ | ||
| sort_order: calc(score * 5, type: :integer) | ||
| }, | ||
| sort: [{calc(score * 5, type: :integer), :desc}] | ||
| ) | ||
| ]) | ||
| |> Ash.Query.sort([{calc(^combinations(:sort_order)), :desc}], prepend?: true) | ||
|
|
||
| result = Ash.read!(query) | ||
| titles = Enum.map(result, & &1.title) | ||
| # Expected order: sort_order DESC, then title ASC | ||
| # Dog(200), Apple(125), Cat(100), Zebra(100) | ||
| expected_title_order = ["Dog", "Apple", "Cat", "Zebra"] | ||
| assert titles == expected_title_order | ||
| end |
There was a problem hiding this comment.
This test appears to be failing on an ecto error.
There was a problem hiding this comment.
That may have been a local glitch. Is now failing locally with an incorrect order.
These tests show that loading calculations in queries that have combinations works.
rellen
force-pushed
the
tests/combination_nullable_calculation_sorting
branch
from
854bde5 to
dd57500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests (should) show that loading calculations in queries that have combinations works.
There is currently a test that is failing here.
Contributor checklist
Leave anything that you believe does not apply unchecked.