Skip to content

Wrap Up #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/controllers/comments_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def new
def edit
respond_to do |format|
format.html
format.js
end
end

Expand All @@ -37,6 +38,10 @@ def create
format.html { render :new, status: :unprocessable_entity }
format.json { render json: @comment.errors, status: :unprocessable_entity }
end

format.js do
render template: "comments/create.js.erb"
end
end
end

Expand All @@ -46,6 +51,7 @@ def update
if @comment.update(comment_params)
format.html { redirect_to root_url, notice: "Comment was successfully updated." }
format.json { render :show, status: :ok, location: @comment }
format.js
else
format.html { render :edit, status: :unprocessable_entity }
format.json { render json: @comment.errors, status: :unprocessable_entity }
Expand All @@ -59,6 +65,9 @@ def destroy
respond_to do |format|
format.html { redirect_back fallback_location: root_url, notice: "Comment was successfully destroyed." }
format.json { head :no_content }
format.js do
render template: "comments/destroy.js.erb"
end
end
end

Expand Down
97 changes: 37 additions & 60 deletions app/controllers/photos_controller.rb
Original file line number Diff line number Diff line change
@@ -1,81 +1,58 @@
class PhotosController < ApplicationController
before_action :set_photo, only: %i[ show edit update destroy ]

before_action :ensure_current_user_is_owner, only: [:destroy, :update, :edit]

# GET /photos or /photos.json
def index
@photos = Photo.all
matching_photos = Photo.all

@list_of_photos = matching_photos.order({ :created_at => :desc })

render({ :template => "photos/index.html.erb" })
end

# GET /photos/1 or /photos/1.json
def show
end
the_id = params.fetch("path_id")

# GET /photos/new
def new
@photo = Photo.new
end
matching_photos = Photo.where({ :id => the_id })

@the_photo = matching_photos.at(0)

# GET /photos/1/edit
def edit
render({ :template => "photos/show.html.erb" })
end

# POST /photos or /photos.json
def create
@photo = Photo.new(photo_params)
@photo.owner = current_user

respond_to do |format|
if @photo.save
format.html { redirect_to @photo, notice: "Photo was successfully created." }
format.json { render :show, status: :created, location: @photo }
else
format.html { render :new, status: :unprocessable_entity }
format.json { render json: @photo.errors, status: :unprocessable_entity }
end
the_photo = Photo.new
the_photo.image = params.fetch("query_image")
the_photo.caption = params.fetch("query_caption")
the_photo.owner_id = params.fetch("query_owner_id")

if the_photo.valid?
the_photo.save
redirect_to("/photos", { :notice => "Photo created successfully." })
else
redirect_to("/photos", { :alert => the_photo.errors.full_messages.to_sentence })
end
end

# PATCH/PUT /photos/1 or /photos/1.json
def update
respond_to do |format|
if @photo.update(photo_params)
format.html { redirect_to @photo, notice: "Photo was successfully updated." }
format.json { render :show, status: :ok, location: @photo }
else
format.html { render :edit, status: :unprocessable_entity }
format.json { render json: @photo.errors, status: :unprocessable_entity }
end
the_id = params.fetch("path_id")
the_photo = Photo.where({ :id => the_id }).at(0)

the_photo.image = params.fetch("query_image")
the_photo.caption = params.fetch("query_caption")
the_photo.owner_id = params.fetch("query_owner_id")

if the_photo.valid?
the_photo.save
redirect_to("/photos/#{the_photo.id}", { :notice => "Photo updated successfully."} )
else
redirect_to("/photos/#{the_photo.id}", { :alert => the_photo.errors.full_messages.to_sentence })
end
end

# DELETE /photos/1 or /photos/1.json


def destroy
@photo.destroy
the_id = params.fetch("path_id")
the_photo = Photo.where({ :id => the_id }).at(0)

respond_to do |format|
format.html { redirect_back fallback_location: root_url, notice: "Photo was successfully destroyed." }
format.json { head :no_content }
end
end

private
# Use callbacks to share common setup or constraints between actions.
def set_photo
@photo = Photo.find(params[:id])
end
the_photo.destroy

def ensure_current_user_is_owner
if current_user != @photo.owner
redirect_back fallback_location: root_url, alert: "You're not authorized for that."
end
end

# Only allow a list of trusted parameters through.
def photo_params
params.require(:photo).permit(:image, :comments_count, :likes_count, :caption, :owner_id)
end
redirect_to("/photos", { :notice => "Photo deleted successfully."} )
end
end
11 changes: 8 additions & 3 deletions app/views/comments/_comment.html.erb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<li class="list-group-item">
<li id="<%= dom_id(comment) %>" class="list-group-item">
<div class="media">
<%= image_tag comment.author.avatar_image, class: "rounded-circle mr-2", width: 36 %>
<div class="media-body">
Expand All @@ -9,11 +9,16 @@

<div>
<% if current_user == comment.author %>
<%= link_to edit_comment_path(comment), class: "btn btn-link btn-sm text-muted" do %>
<%= link_to edit_comment_path(comment),
class: "btn btn-link btn-sm text-muted",
remote: true do %>
<i class="fas fa-edit fa-fw"></i>
<% end %>

<%= link_to comment, method: :delete, class: "btn btn-link btn-sm text-muted" do %>
<%= link_to comment,
method: :delete,
class: "btn btn-link btn-sm text-muted",
remote: true do %>
<i class="fas fa-trash fa-fw"></i>
<% end %>
<% end %>
Expand Down
4 changes: 2 additions & 2 deletions app/views/comments/_form.html.erb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<li class="list-group-item">
<%= form_with(model: comment) do |form| %>
<li id="<%= dom_id(comment.photo) %>_<%= dom_id(comment) %>_form" class="list-group-item">
<%= form_with(model: comment, local:false) do |form| %>
<% if comment.errors.any? %>
<div id="error_explanation">
<ul class="list-unstyled">
Expand Down
5 changes: 5 additions & 0 deletions app/views/comments/destroy.js.erb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
console.log("bye comment!")

$("#<%= dom_id(@comment) %>").fadeOut(1000, function() {
$(this).remove();
});