examples/mtdpart:Register MTD devices using the mtd_register method #3130
+110
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingfei195887
force-pushed
the
mtd_optimize
branch
from
35c3954 to
1229352
Compare
|
please fix: |
sure, working on this now |
jingfei195887
force-pushed
the
mtd_optimize
branch
from
06705ab to
1c2b33e
Compare
done |
|
still have ci error, please run checkpatch.sh before you update patch. @jingfei195887 |
jingfei195887
force-pushed
the
mtd_optimize
branch
from
1c2b33e to
babf87b
Compare
1. Due to the automatic wrapping of MTD devices during the open() process, the legacy registration methods ftl_initialize() and bchdev_register() are no longer required for MTD device registration. The new method is now changed to register_mtddriver 2. Some code for space release and deregistration has been added, and certain error handling methods have been updated.
jingfei195887
force-pushed
the
mtd_optimize
branch
from
babf87b to
27ba699
Compare
| @@ -204,7 +194,9 @@ int main(int argc, FAR char *argv[]) | |||
| if (ret < 0) | |||
| { | |||
| ferr("ERROR: mtd->ioctl failed: %d\n", ret); | |||
| exit(3); | |||
| unregister_mtddriver("/dev/mtd0"); | |||
There was a problem hiding this comment.
move to the end and add label err_mtd
| @@ -317,8 +294,9 @@ int main(int argc, FAR char *argv[]) | |||
| if (nbytes < 0) | |||
| { | |||
| printf("ERROR: write to /dev/mtd0 failed: %d\n", errno); | |||
| fflush(stdout); | |||
| exit(9); | |||
| close(fd); | |||
There was a problem hiding this comment.
move close to the end and add label err_fd
| fflush(stdout); | ||
| exit(1); | ||
| status = 1; | ||
| goto errout; |
There was a problem hiding this comment.
Suggested change
| goto errout; | |
| goto err; |
| @@ -133,8 +133,7 @@ int main(int argc, FAR char *argv[]) | |||
| FAR struct mtd_dev_s *part[CONFIG_EXAMPLES_MTDPART_NPARTITIONS + 1]; | |||
| FAR struct mtd_geometry_s geo; | |||
| FAR uint32_t *buffer; | |||
| printf("ERROR: error status %d\n", status); | ||
| } | ||
|
|
||
| if (buffer) |
|
|
||
| if (status) | ||
| { | ||
| printf("ERROR: error status %d\n", status); |
There was a problem hiding this comment.
remove the unnecessary log
| free(buffer); | ||
| } | ||
|
|
||
| if (master) |
There was a problem hiding this comment.
need zero at line 132, please fix ALL warning before submit your change.
| fflush(stdout); | ||
| exit(7); | ||
| status = 6; | ||
| goto errout; |
| exit(3); | ||
| printf("ERROR: register_mtddriver /dev/mtd0 failed: %d\n", ret); | ||
| status = 2; | ||
| goto errout; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to the automatic wrapping of MTD devices during the open() process, the legacy registration methods ftl_initialize() and bchdev_register() are no longer required for MTD device registration. The new method is now changed to register_mtddriver
Some code for space release and deregistration has been added, and certain error handling methods have been updated.
Test
Run the
examples/mtdpartin sim:nsh for test an test is passed