Add support for custom credential loader for S3 FileIO #1528
+291
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Adds the ability to provide custom extensions to the
FileIOBuilder
. Currently the only supported extension isCustomAwsCredentialLoader
which is a newtype aroundAwsCredentialLoad
, which is what OpenDAL expects.I've added extensions to the
RestCatalog
as well, and when its constructingFileIO
for table operations, passes along any defined extensions into theFileIOBuilder
, which then get passed into the underlying OpenDAL constructors.Are these changes tested?
Yes, tests added in
crates/iceberg/tests/file_io_s3_test.rs
that verify the extension is working.