Rest: Implement register table #1521
Open
+212
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabeiglio
force-pushed
the
rest-register-table
branch
from
0bfda56 to
5c342f3
Compare
gabeiglio
commented
Jul 17, 2025
Comment on lines
+804
to
+814
| StatusCode::SERVICE_UNAVAILABLE => { | ||
| return Err(Error::new( | ||
| ErrorKind::Unexpected, | ||
| "The service is not ready to handle the request.", | ||
| )); | ||
| } | ||
| StatusCode::INTERNAL_SERVER_ERROR => { | ||
| return Err(Error::new( | ||
| ErrorKind::Unexpected, | ||
| "An unknown server-side problem occurred; the commit state is unknown.", | ||
| )); |
gabeiglio
commented
Jul 17, 2025
Comment on lines
+780
to
+791
| StatusCode::UNAUTHORIZED => { | ||
| return Err(Error::new( | ||
| ErrorKind::Unexpected, | ||
| "Authenticated user does not have the necessary permissions.", | ||
| )); | ||
| } | ||
| StatusCode::FORBIDDEN => { | ||
| return Err(Error::new( | ||
| ErrorKind::Unexpected, | ||
| "Authenticated user does not have the necessary permissions.", | ||
| )); | ||
| } |
There was a problem hiding this comment.
Also not sure if we need to check for these cases
gabeiglio
force-pushed
the
rest-register-table
branch
from
5c342f3 to
574069f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?
Im new to Rust so any feedback is welcomed! :)