Skip to content

fix(android): Use cdvPluginPostBuildExtras instead of ext.postBuildExtras (CB-14163) #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

merrygobyebye
Copy link

@merrygobyebye merrygobyebye commented Jul 1, 2018

Use cdvPluginPostBuildExtras instead of ext.postBuildExtras

Platforms affected

Android

What does this PR do?

  1. Adds a reference to the build-extras.gradle file in plugin.xml so that the code in build-extras.gradle will run with the main Cordova build.gradle.
  2. Replaces incorrect usage of ext.postBuildExtras with usage of cdvPluginPostBuildExtras.

What testing has been done on this change?

Added the modified cordova-plugin-file to a Cordova project and verified that the code in build-extras.gradle ran during the execution of the command cordova build android.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

…of cdvPluginPostBuildExtras * Add reference to build-extras.gradle in plugin.xml
@janpio janpio changed the title CB-14163 fix(android): Use cdvPluginPostBuildExtras instead of ext.postBuildExtras (CB-14163) Jul 4, 2019
@janpio janpio closed this Jul 4, 2019
@janpio
Copy link
Member

janpio commented Jul 4, 2019

Run current tests

@janpio janpio reopened this Jul 4, 2019
@janpio janpio closed this Jul 4, 2019
@janpio
Copy link
Member

janpio commented Jul 4, 2019

CI: Once more please.

@janpio janpio reopened this Jul 4, 2019
@BrianMulhall
Copy link

is this change needed? I am curious if I should be running the code
defined in the build-extras.gradle file

@breautek
Copy link
Contributor

For context, the original issue this PR addresses is on jira at https://issues.apache.org/jira/browse/CB-14163

The motivation appears to be a bug if multiple plugins are trying to use ext.postBuildExtras where one will overwrite the other (as claimed in the bug report).

@BrianMulhall
Copy link

if the plugin.xml doesnt have the change in this pull request the build-extras.gradle wont exist in the build output. So I am really wondering if the contents of the build-extras.gradle needs to be run at all. Cause if it does then i think this change is important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants