Skip to content

fix(android): getDirectory("") returns current path instead of / path (CB-13849) #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Beutlin
Copy link
Contributor

@Beutlin Beutlin commented Feb 6, 2018

Platforms affected

  • Android

What does this PR do?

Currently the comman getDirectory('') with an empty parameter returns always the root path. It does not matter on which path this command is executed. This is an unexpected behaviour and might cause security issues.
With this patch the path of the current directory is returned, like in other implementations (i.e. browser).

What testing has been done on this change?

It has been tested on an emulator. Furthermore the sourcecode has been evaluated and there is no negative issues with it.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@janpio
Copy link
Member

janpio commented Oct 1, 2018

Hey, I just fixed the problem that caused Android tests to fail in master. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR.

@Beutlin
Copy link
Contributor Author

Beutlin commented Oct 14, 2018

I've rebased my PR.
Nevertheless there are some issues with node.js and Safari.
I'm very certain that I have changed only Android relevant files. If I still get an error the problem must be with your build toolchain.

@janpio
Copy link
Member

janpio commented Oct 30, 2018

Yes, see #257

@janpio janpio changed the title CB-13849: (android) getDirectory("") returns current path instead of / path fix(android): getDirectory("") returns current path instead of / path (CB-13849) Jul 4, 2019
@janpio janpio closed this Jul 4, 2019
@janpio
Copy link
Member

janpio commented Jul 4, 2019

Rerun tests.

@janpio janpio reopened this Jul 4, 2019
@janpio janpio closed this Jul 4, 2019
@janpio
Copy link
Member

janpio commented Jul 4, 2019

CI: Once more please.

@janpio janpio reopened this Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants